Use permalink for Logger::Severity #3013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaylareopelle
requested review from
hannahramadan and
tannalynn
as code owners
SimpleCov Report
|
tannalynn
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby moved the logger code out of the ruby/ruby repository. This change uses the ruby/logger repository and also uses a permalink.
I imagine the newrelic.yml changes will be updated again whenever we release, so I just added the permalink to the existing setup to get the URL CI to pass.
Passing URL CI: https://github.com/newrelic/newrelic-ruby-agent/actions/runs/12755313559 🟢