Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: upgrade for native sidecars (#471) #472

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmerrill3
Copy link

Description

Fix for Issue #471

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • New feature / enhancement (non-breaking change which adds functionality)
  • Security fix
  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • Add changelog entry following the contributing guide
  • Documentation has been updated
  • This change requires changes in testing:
    • unit tests
    • E2E tests

@mmerrill3 mmerrill3 requested a review from a team as a code owner September 20, 2024 21:42
@CLAassistant
Copy link

CLAassistant commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 77.24%. Comparing base (bcb8cb7) to head (633ee5a).
Report is 10 commits behind head on main.

Files with missing lines Patch % Lines
internal/operator/operator.go 0.00% 9 Missing ⚠️
internal/operator/pod_mutator_handler.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (bcb8cb7) and HEAD (633ee5a). Click for more details.

HEAD has 23 uploads less than BASE
Flag BASE (bcb8cb7) HEAD (633ee5a)
24 1
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
- Coverage   83.67%   77.24%   -6.44%     
==========================================
  Files           6        9       +3     
  Lines         435      479      +44     
==========================================
+ Hits          364      370       +6     
- Misses         60       97      +37     
- Partials       11       12       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants