Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update Home project dependencies #2954

Merged
merged 2 commits into from
Jan 16, 2025

Conversation

tippmar-nr
Copy link
Member

@tippmar-nr tippmar-nr commented Jan 16, 2025

The memcached project was not a dependency of the Home project, which could have led to changes not getting built for local testing.

Also addresses the security issue that was flagged in build_buildtools.yml by correctly pinning the action dependency.

@tippmar-nr tippmar-nr requested a review from a team as a code owner January 16, 2025 17:35
@tippmar-nr tippmar-nr enabled auto-merge (squash) January 16, 2025 17:35
chynesNR
chynesNR previously approved these changes Jan 16, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.79%. Comparing base (f70b64a) to head (4089ecf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2954      +/-   ##
==========================================
- Coverage   81.82%   81.79%   -0.04%     
==========================================
  Files         470      470              
  Lines       29949    29949              
  Branches     3327     3327              
==========================================
- Hits        24507    24496      -11     
- Misses       4647     4660      +13     
+ Partials      795      793       -2     
Flag Coverage Δ
Agent 82.74% <ø> (-0.05%) ⬇️
Profiler 73.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 4 files with indirect coverage changes

@tippmar-nr tippmar-nr merged commit ee0dd2b into main Jan 16, 2025
95 checks passed
@tippmar-nr tippmar-nr deleted the chore/project-dependency-update branch January 16, 2025 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants