fix: Incorrect string comparison in the profiler caused constructor i…

…nstrumentation to fail on Linux (#2912)
newrelic · Dec 5, 2024 · 49a71c5 · 49a71c5
1 parent 10bcd22
commit 49a71c5
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/.gitignore b/.gitignore
@@ -49,8 +49,14 @@ tests/Agent/IntegrationTests/.vs/config/applicationhost.config
 .DS_Store
 
 # Local profiler build artificats
-src/Agent/_profilerBuild/*Debug
-src/Agent/NewRelic/Profiler/Profiler/VersionInfo.h
+/src/Agent/_profilerBuild/*Debug
+/src/Agent/NewRelic/Profiler/Profiler/VersionInfo.h
+/src/Agent/NewRelic/Profiler/CMakeFiles
+/src/Agent/NewRelic/Profiler/CMakeCache.txt
+/src/Agent/NewRelic/Profiler/cmake_install.cmake
+/src/Agent/NewRelic/Profiler/Makefile
+/src/Agent/_profilerBuild/x64-Release
+/src/Agent/_profilerBuild/x86-Release
 
 # Ignore any signing keys used in Linux packaging
 build/Linux/keys

diff --git a/src/Agent/NewRelic/Home/Home.csproj b/src/Agent/NewRelic/Home/Home.csproj
@@ -13,7 +13,7 @@
   </Target>
 
   <ItemGroup>
-    <PackageReference Include="NewRelic.Agent.Internal.Profiler" Version="10.33.1.6"/>
+    <PackageReference Include="NewRelic.Agent.Internal.Profiler" Version="10.34.0.14"/>
   </ItemGroup>
 
 </Project>
diff --git a/src/Agent/NewRelic/Profiler/MethodRewriter/Instrumentors.h b/src/Agent/NewRelic/Profiler/MethodRewriter/Instrumentors.h
@@ -55,7 +55,7 @@ namespace NewRelic { namespace Profiler { namespace MethodRewriter
             // some special name methods seem to give us trouble, but allow constructors to
             // be instrumented
             if (IsMdSpecialName(function->GetMethodAttributes()) &&
-                    !IsMdInstanceInitializerW(function->GetMethodAttributes(), function->GetFunctionName().c_str())) {
+                    function->GetFunctionName() != _X(".ctor")) {
                 LogError(L"Skipping SpecialName method: ", function->ToString());
                 return false;
             }