ci: move signing packages to automation page #105
Conversation
abhishuraina
force-pushed
the
NR-352659-modify-signing-for-packages-to-sha-256
branch
2 times, most recently
from
782f352 to
2356e4c
Compare
abhishuraina
force-pushed
the
NR-352659-modify-signing-for-packages-to-sha-256
branch
from
2356e4c to
b1b40c2
Compare
There was a problem hiding this comment.
have you checked already that all the repos share the same script?
There was a problem hiding this comment.
Adding some context for the scripts:
These are only needed for FIPS. As we need to use Ubuntu 16 for building FIPS packages at this time (it might change with go 1.24), and there is some issue with using goreleaser signing with Ubuntu 16 as it prompts for password and non-interactive doesn't work (multiple tests done for this).
TL;DR
This script will be same for all the OHIs that need the packages to be signed.
| @@ -47,5 +47,6 @@ ENV GOFLAGS="-buildvcs=false" | |||
| # Since the user does not match the owners of the repo "git rev-parse --is-inside-work-tree" fails and goreleaser does not populate projectName | |||
| # https://stackoverflow.com/questions/72978485/git-submodule-update-failed-with-fatal-detected-dubious-ownership-in-repositor | |||
| RUN git config --global --add safe.directory '*' | |||
| COPY ./sign.sh ./sign_deb.exp ./sign_rpm.exp ./sign_tar.exp /usr/local/bin | |||
There was a problem hiding this comment.
We are only copying the files since they are executed already in the makefile? https://github.com/newrelic/nri-redis/pull/212/files#diff-553b9a740f0151f2e959512198dddbdd0d69c398d29583ca0a4e011d5598932e
Modify signing packages to SHA-256 and move the signing files from integrations to automations repo.