Nr 341876 make docker images pre release uniform #103
Conversation
|
Tested with all the docker image releases that were automated so far
|
| - name: Generate version from tag | ||
| run: | | ||
| TAG_WITHOUT_V=$(echo "${{ env.TAG }}" | sed 's/^v//') | ||
| echo "VERSION=$TAG_WITHOUT_V" >> $GITHUB_ENV |
There was a problem hiding this comment.
also this, there if no guarantee the different repos using a custom build command are checking "VERSION"
There was a problem hiding this comment.
All the repos release actions and scripts were modified to use DOCKER_IMAGE_TAG env variable for the tag.
VERSION and TAG_SUFFIX are no longer used.
There was a problem hiding this comment.
is it true also for nri-prometheus? I do not see such change in this PR https://github.com/newrelic/nri-prometheus/pull/511/files
| - name: Add pre-release tag suffix | ||
| if: ${{ github.event.release.prerelease }} | ||
| run: | | ||
| echo "TAG_SUFFIX=-pre" >> $GITHUB_ENV |
There was a problem hiding this comment.
Since only prometheus needs this. Set this in the prometheus build command.
| ORIGINAL_REPO_NAME: ${{ inputs.original_repo_name }} | ||
| REPO_FULL_NAME: ${{ github.event.repository.full_name }} | ||
| INTEGRATION: ${{ inputs.integration_name }} | ||
| S3_PATH: ${{ inputs.bucket_url }} |
There was a problem hiding this comment.
S3_PATH and other variables needed only by prometheus can be setup in the build command.
Testing the docker image releases one by one.
Can be merged once thats done.