[DashboardLayout] Add roles to navigation

[bharatkashyap]

• Closes [core] Support RBAC in AppProvider #4120
• Add a roles: string[] to NavigationPageItem
• Add groups?: string[] and roles?: string[] to Session
• Check if user.groups or user.roles has a matching role in hasMatchingRole
• Remove pages from navigation and render a 404 on navigation to pages for which there is no access
• Remains agnostic to the method of providing the roles or groups on the session object

[Janpot]

I'm hesitant building anything RBAC before we have the CRUD features and have set up a pro version.

instead I think we could add a way to disable items through a callback, just like how it's done with treeview or datagrid. that way it and other use cases can be built in userland. use cases which can be then used to validate an RFC.

[bharatkashyap]

I'm hesitant building anything RBAC before we have the CRUD features and have set up a pro version.

We discussed this week that given #4120 is the most upvoted (and fastest growing in upvotes) issue, does it make sense to keep a minimal version of the roles feature blocked till the entirety of CRUD has landed?

Once we have CRUD and the pro version, we can integrate the roles we define here with the ability to restrict some CRUD actions on some resources.

Wdyt?

[Janpot]

My thinking was that there are more ways to do authorization than RBAC. Some users may only need a very simple setup , such as checking against an email address. We could serve more kinds of users with a less opinionated API. Then see which usage parents emerge and provide convenience APIs for the most used ones. I feel like now we're locking every use case into RBAC.

[JuR-0]

As @Janpot mentioned, adding a simple callback driving the display of navigation items could solve any RBAC needs as well as many other. (discussed in #4607 )

Then RBAC would just be:

• A custom session
• A callback leveraging roles/groups as needed

The availability of content can be tackled at the page level by the user as a first approach
Is it the goal we are pursuing ? if yes I could work on a draft