[core] Add exports field and build proper ES modules (no import extensions variant) #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaldudak
changed the title
michaldudak
force-pushed
the
esm-build-no-extensions
branch
from
f9f04cd
to
417dc87
Compare
Netlify deploy preview |
michaldudak
force-pushed
the
esm-build-no-extensions
branch
from
417dc87
to
d6e7a86
Compare
|
I'd expected the result after running tsc-alias to be the same regardless of esm or cjs. isn't that the case if you used the same file extension for both? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a variant of #745 that does not require file extensions in import/export specifiers. It uses
babel-plugin-add-import-extensionto modify JS files andtsc-aliasto modify type definitions.I initially wanted to generate type definitions once, run
tsc-aliason them and then copy them to /esm and /cjs directories, buttsc-aliaslooks for actual files the .d.ts file references, so it must be run in-place.