Update open-edx pipeline to match SQL file output for Simeon #622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blarghmatey
reviewed
Mar 21, 2023
There was a problem hiding this comment.
Looking good so far. A couple minor comments. In terms of PyPika vs. raw SQL I don't have a strong opinion on it. If it takes a little longer to write now but seems more maintainable in the future, then I'm happy to go that direction. If the SQL is faster and more maintainable then I'm happy with that option too.
| Query.from_(course_team) | ||
| .join(teams_membership) | ||
| .on(course_team.id == teams_membership.team_id) | ||
| .select("teams_membership.*") |
There was a problem hiding this comment.
Suggested change
| .select("teams_membership.*") | |
| .select("teams_courseteammembership.*") |
…atedCertificateTask, AuthUserTask, AuthUserProfileTask
…atedCertificateTask, AuthUserTask, AuthUserProfileTask
for more information, see https://pre-commit.ci
blarghmatey
reviewed
Mar 23, 2023
| """ | ||
| wiki_article, wiki_urlpath = Tables("wiki_article", "wiki_urlpath") | ||
| subquery = ( | ||
| Query.from(wiki_urlpath).as_("node").from(wiki_urlpath).as("parent") |
There was a problem hiding this comment.
Suggested change
| Query.from(wiki_urlpath).as_("node").from(wiki_urlpath).as("parent") | |
| Query.from_(wiki_urlpath).as_("node").from(wiki_urlpath).as("parent") |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Initial commit, adding TeamsMembership Query
Motivation and Context
Open edX data exports from Open Learning should conform to the edx-analytics-exporter interface output
#610
How Has This Been Tested?
Types of changes
Checklist: