Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type definition entry point #1315

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

heuuLZP
Copy link

@heuuLZP heuuLZP commented Jun 30, 2024

Hello, I'm currently using version 8.0.1, but I still encountered this issue Cannot find type definition file for 'minio' yesterday.

The current entry point "types": "./types/esm/minio.d.ts" is incorrect, and the actual directory 'types' does not exist, as shown in the screenshot below.

image image

The correct address should be "types": "./dist/main/minio.d.ts"

@heuuLZP
Copy link
Author

heuuLZP commented Jul 19, 2024

Does anyone pay attention to this PR? This may be a very minor problem, please confirm whether it needs to be dealt with
@prakashsvmx

Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with
fix: minio type definition not exported in package.json. close #1257.

So please double check and provide a reproducer to validate it.

@heuuLZP
Copy link
Author

heuuLZP commented Jul 25, 2024

I made some attempts but didn't achieve any results. I also don't know how to test.
Or maybe we can think about it differently.
What does the .type directory in package.json represent? Can you explain that? Why would someone write a non-existent directory name?

截屏2024-07-25 16 08 01

截屏2024-07-25 16 12 24

@heuuLZP
Copy link
Author

heuuLZP commented Jul 25, 2024

But the directory ./dist/main/minio.d.ts exists relative to .type

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants