Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moved weatherKey and coordinates to local storage #141

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thefudgeishot
Copy link

Changed config.js to store certain information in local storage instead of plain text.

@lewisdoesstuff
Copy link
Contributor

I think it'd be best to add another config option for this, or maybe only prompt when the key/lat/long values are undefined/null in the config.

As is, this would break weather across shared instances, requiring each user to input an API key.

It's only an OpenWeatherMap key; I don't really see a problem with it being plaintext.

@migueravila
Copy link
Owner

@thefudgeishot I love this purpose. And I think we should add it but yes. I think it should be easier to set it. I think we should double check on this. I'm sorry to not having the time for updating this project but I promise on keep updating it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants