Entity: Add class list rather than replace directly #2752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,12 +107,11 @@ function parseEntityClassName( | |||
| * @param format The source entity format object | |||
| * @returns A combined CSS class name string for entity wrapper | |||
| */ | |||
| export function generateEntityClassNames(format: ContentModelEntityFormat): string { | |||
| export function generateEntityClassList(format: ContentModelEntityFormat): string[] { | |||
There was a problem hiding this comment.
Changing the function name may be a breaking change as it is already exported in the index file, suggest create a new function.
|
@Echo-az please fix test files. Also could you please verify if this is not going to cause duplicate Entity Classes in elements and add unit test to validate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
classList.addrather than settingclassNamefor entity wrapper to avoid original class loss.