You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restore the changes reverted by 205802b and fix a bug that was causing use after free (the for loop for computing oldest epoch was malformed resulting in a no-op).
Note: This is intentionally three or more commits:
Restore the reverted code (including the bug).
Fix the bug.
PR feedback and addition of new tests.
Testing
CI/CD + 24 hour run of api_test.exe (previously failing after 2 hours).
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪
🧪 PR contains tests
🔒 No security concerns identified
⚡ Recommended focus areas for review
Thread Safety The code modifies shared state without sufficient synchronization mechanisms in several places, which could lead to race conditions or data corruption in a multi-threaded environment.
Resource Leak The new implementation introduces potential resource leaks where allocated resources on error paths are not always properly freed or handled.
Error Handling Error paths may not correctly restore previous states, potentially leaving the system in an inconsistent state after an error.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alan-Jowett
force-pushed
the
cpu_activation
branch
6 times, most recently
from
Description
Restore the changes reverted by 205802b and fix a bug that was causing use after free (the for loop for computing oldest epoch was malformed resulting in a no-op).
Note: This is intentionally three or more commits:
Testing
CI/CD + 24 hour run of api_test.exe (previously failing after 2 hours).
Documentation
Yes, in the files.
Installation
No.