-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AOT] Clean up some AOT issues in Advanced Paste module #36297
base: main
Are you sure you want to change the base?
Changes from 8 commits
ee1dba5
93fe40d
4d428c8
14a1bb6
046ab9a
839dba7
5d814e0
ff532d0
dcd9603
fbef327
eddcb1c
1aca55f
a362d33
699df28
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
// Copyright (c) Microsoft Corporation | ||
// The Microsoft Corporation licenses this file to you under the MIT license. | ||
// See the LICENSE file in the project root for more information. | ||
|
||
using System.Text.Json.Serialization; | ||
using AdvancedPaste.Models.KernelQueryCache; | ||
|
||
namespace AdvancedPaste.Helpers; | ||
|
||
[JsonSerializable(typeof(PersistedCache))] | ||
[JsonSerializable(typeof(LogEvent))] | ||
[JsonSourceGenerationOptions(UseStringEnumConverter = true)] | ||
public sealed partial class AdvancedPasteJsonSerializerContext : JsonSerializerContext | ||
{ | ||
} |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,21 @@ | ||||||
// Copyright (c) Microsoft Corporation | ||||||
// The Microsoft Corporation licenses this file to you under the MIT license. | ||||||
// See the LICENSE file in the project root for more information. | ||||||
|
||||||
using System.Text.Json; | ||||||
using AdvancedPaste.Models.KernelQueryCache; | ||||||
|
||||||
namespace AdvancedPaste.Helpers | ||||||
{ | ||||||
public class LogEvent | ||||||
{ | ||||||
public LogEvent(object message) | ||||||
{ | ||||||
this.message = message; | ||||||
} | ||||||
|
||||||
private object message; | ||||||
|
||||||
public string ToJsonString() => JsonSerializer.Serialize(this, AdvancedPasteJsonSerializerContext.Default.PersistedCache); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Also, I believe the Since we know There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sure, I agree. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let me consider how to make this interface easy to use. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @snickler |
||||||
} | ||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Rename to
AIServiceFormatEvent