Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change default FieldLabel el from label to div (breaking change) #627

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

IMythx
Copy link
Contributor

@IMythx IMythx commented Sep 25, 2024

steps to reproduce

1-go to docs > Api refrence > Fields > Array

2- click on any of the array items and you will notice it will cause a deletion as if you clicked on delete button

fixs #528

Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
puck-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 7, 2024 3:50pm
puck-docs ✅ Ready (Inspect) Visit Preview Oct 7, 2024 3:50pm

Copy link

vercel bot commented Sep 25, 2024

@IMythx is attempting to deploy a commit to the Measured Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Member

@chrisvxd chrisvxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks @IMythx!

However, this will be a feature as it's an API change, so I'm not going to merge it until we're closer to v0.17.0.

@chrisvxd chrisvxd changed the title fix:fix docs array field deletion on click feat: change default FieldLabel el from label to div (breaking change) Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants