Simplify installation instructions #436
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m2-community-project
bot
added
Progress: review
and removed
Progress: ready for review
labels
ihor-sviziev
previously approved these changes
Apr 12, 2023
Den4ik
previously approved these changes
Apr 12, 2023
|
@magento import PR to magento-commerce/magento-coding-standard repository |
|
@sinhaparul the Pull Request is successfully imported. |
ihor-sviziev
previously approved these changes
Jun 12, 2023
ihor-sviziev
previously approved these changes
Aug 14, 2023
fredden
force-pushed
the
simplify-install-instructions
branch
2 times, most recently
from
6d8a941
to
afe826d
Compare
6 tasks
fredden
force-pushed
the
simplify-install-instructions
branch
from
afe826d
to
2d3d36e
Compare
ihor-sviziev
previously approved these changes
Dec 11, 2023
fredden
force-pushed
the
simplify-install-instructions
branch
from
2d3d36e
to
e43bd79
Compare
fredden
force-pushed
the
simplify-install-instructions
branch
from
556edd4
to
7143ee5
Compare
ihor-sviziev
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation instructions for this coding standard are unnecessarily complex. Composer plugins are capable of performing the necessary registration automatically, without requiring the user to manually set up (or alter) any
scriptssections incomposer.json. The main Magento repository usesdealerdirect/phpcodesniffer-composer-installerto register the coding standard; let's use the same here.See https://github.com/magento/magento2/blob/11846a1a10539470f2fe1522030ff42d62daa562/composer.json#L110 / magento/magento2#36791
Fixes #390