Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes dependency on node.js util module #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Removes dependency on node.js util module #17

wants to merge 1 commit into from

Conversation

deive
Copy link

@deive deive commented Sep 26, 2017

Removes dependency on node.js util module (by copying the only used inherits method to customUtils).

@JamesMGreene
Copy link
Contributor

I'd advise just relying on the NPM module inherits instead. It results in a much smaller browser bundle than including util (as in master), works for non-Node.js environments (e.g. React Native as in #14), and avoids including a custom inheritance method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants