fix(pro): always check for available template updates and wait for changed parameters to be applied #1567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkneis
reviewed
Jan 16, 2025
bkneis
reviewed
Jan 16, 2025
bkneis
reviewed
Jan 16, 2025
bkneis
approved these changes
Jan 16, 2025
janekbaraniewski
approved these changes
Jan 16, 2025
changed parameters to be applied Changes the template behaviour for pro instances like so: 1. If template is not versioned _always_ keep the workspace in sync with template, even if that means rescheduling due to workspace changes 2. If the template is versioned and the workspace uses an explicit version we keep the workspace up to date with the template unless a new version is available. We expect versioned templates to introduce changes through a new version, not by updating an existing version In addition to that we now wait until the server applied parameter changes instead of assuming it did in time. This fixes a race condition where the parameter changes wouldn't be applied if the controller took more than a couple ms
pascalbreuninger
force-pushed
the
fix/apply-template-updates
branch
from
bc7357e to
82901b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the template behaviour for pro instances like so:
with template, even if that means rescheduling due to workspace
changes
version we keep the workspace up to date with the template unless a
new version is available. We expect versioned templates to introduce
changes through a new version, not by updating an existing version
In addition to that we now wait until the server applied parameter
changes instead of assuming it did in time. This fixes a race condition
where the parameter changes wouldn't be applied if the controller took
more than a couple ms