[Torch Dialect] Emit torch.aten.mul.float_int, add folder and conversion to Arith.
#3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjgarvey
requested changes
Nov 8, 2024
| // CHECK-SAME: %[[RHS:.*]]: !torch.int) -> !torch.float { | ||
| // CHECK-DAG: %[[LHS_F64:.*]] = torch_c.to_f64 %[[LHS]] | ||
| // CHECK-DAG: %[[RHS_I64:.*]] = torch_c.to_i64 %[[RHS]] | ||
| // CHECK: %[[MUL:.*]] = arith.mulf %[[LHS_F64:.*]], [[RHS_I64:.*]] : f64 |
There was a problem hiding this comment.
Similar to the other PR, I'm certain there is an additional arith.sitofp op, and the arguments for arith.mulf shouldn't be assignments of variables.
There was a problem hiding this comment.
Correcting here as well.
| return nullptr; | ||
| } | ||
| return atenBinaryFloatOperatorFoldHelper( | ||
| adaptor.getOperands(), [](double a, double b) { return a * b; }); |
There was a problem hiding this comment.
Similar to my comment in your other PR, one of the two arguments should be an int64_t, and it would be beneficial to have additional folding options for whenever one of the two operands is 1 or 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folder is required to simplify the shape calculation of
torch.aten.__interpolate.size_list_scale_list:torch-mlir/lib/Dialect/Torch/Transforms/AbstractInterpLibrary.cpp
Lines 6900 to 6907 in 5eab669
(I've re-run
build_tools/update_abstract_interp_lib.sh)