[CIR] Add support for array new #1286
Open
+590
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds initial support for array new expressions where the array size is constant. This includes implementing the array cookie generation in the CIR CXXABI code, but only for the base Itanium ABI. A subsequent patch will create a subclass of CIRGenItaniumCXXABI to provide the proper array cookie support for AppleARM64 targets. This patch does not support variable array sizes or asan handling, both of which are marked as "NYI".
|
I realize that the test cases here don't actually require an allocation cookie. I'm working on that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds initial support for array new expressions where the array size is constant. This includes implementing the array cookie generation in the CIR CXXABI code, but only for the base Itanium ABI. A subsequent patch will create a subclass of CIRGenItaniumCXXABI to provide the proper array cookie support for AppleARM64 targets.
This patch does not support variable array sizes or special asan handling, both of which are marked as "NYI".