[FIRRTL] Add a new FIRRTL annotation to specify type lowering behavior of module body #7751
+167
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
force-pushed
the
dev/hidetou/convention-atr
branch
2 times, most recently
from
2160b4d
to
c61bffc
Compare
uenoku
commented
Oct 30, 2024
uenoku
force-pushed
the
dev/hidetou/convention-atr
branch
2 times, most recently
from
2c369d2
to
96b6abd
Compare
uenoku
changed the title
uenoku
force-pushed
the
dev/hidetou/convention-atr
branch
from
96b6abd
to
315832d
Compare
…r of module body This allows more fine-grained control over how types are lowered in different contexts. This also adds an "includeHierarchy" option to Convention annotations that allows applying the convention to all modules in the hierarchy below the annotated module.
uenoku
force-pushed
the
dev/hidetou/convention-atr
branch
from
315832d
to
35a3766
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new annotation to control type lowering behavior for internal signals
within a module, separate from the port convention. This allows more fine-grained
control over how aggregate types are handled inside modules.
The new annotation works similarly to ConventionAnnotation but applies to
internal signals rather than module ports. It supports the same conventions
and includes an 'includeHierarchy' option to apply the setting to all
modules in the hierarchy.