Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][CAPI] Add documentation #7668

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[FIRRTL][CAPI] Add documentation #7668

wants to merge 1 commit into from
+94 −2

Conversation

SpriteOvO
Copy link
Member

Add documentation for all FIRRTL C-API public items.

@sequencer
Copy link
Contributor

I think we can add more documentation for the unittest for firrtl.c? and provide a link to the panamaconverter usage from chisel.

@SpriteOvO
Copy link
Member Author

I think we can add more documentation for the unittest for firrtl.c? and provide a link to the panamaconverter usage from chisel.

IMO, the test doesn't really need to be doc, they are all MLIR stuff, and these API are all already well documented.

I have added a link to Chisel example in the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpriteOvO @sequencer