-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide guidelines to integrate external codes #27
Conversation
I skimmed through your proposal, very useful. A couple of thoughts for discussion. It seems to me that the instructions fit perfectly the case of well-developed stand-alone public libraries that have many applications beyond LiteBIRD. I think this circumstance won't be the most frequent one. In particular, I think the instructions lean towards keeping the code outside of the repository, which shouldn't be always the case, to my view. Here are three ideas that I feel missing, let me know what you think.
|
Thanks @ziotom78!! I have the same comment as @dpole. I think we should primarily provide guidelines on how to import in this repo codes that are specifically developed for litebird and that therefore should be copied here. Are we going to proceed with pull requests as @dpole proposed? I think we should, but in the guidelines we should probably write down which must be the basic features that a code must have before submitting the PR. A couple of examples:
If you think it is useful I can open a PR with my module on map based sims, and use it as a test case. |
I think that we should keep a low threshold for PR. I only see pros in sharing codes as early as possible and get feedback even in the development stage. We can place a safety net by requiring an admin to authorize any merge with master. Happy to hear about other's view, of course! |
I believe general guidelines should be given, so that anyone who is in the phase of implementing a new piece of pipeline which will be then import here can start doing it in the proper way. In this way we can minimize the work needed from our side to approve the PR |
It would be very nice if @NicolettaK create a PR, and we all add commits to this PR to fix the document. (Yes, I agree that we should cover the case where people are going to write new code from scratch as well.) This week I'll be busy with exams (again!), so I fear I'll not be able to put much effort in this. |
The updates makes the text more in line with the changes proposed in PR46 (#46).
I re-read the text and found that fixing it was much less difficult than expected: apart from a few sentences here and there, the content was already appropriate for LiteBIRD-specific codes as well. The text should be ready for being integrated IMHO, but please have a check. |
This PR integrates a section in the documentation, which should address issue #26 .