Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SVGO all files and updatefill="#000" to fill="#000001" #1193

Merged
merged 1 commit into from
Dec 11, 2023
Merged

SVGO all files and updatefill="#000" to fill="#000001" #1193

merged 1 commit into from
Dec 11, 2023

Conversation

lipis
Copy link
Owner

@lipis lipis commented Dec 11, 2023 •
edited
Loading 

before: 4.330.398 bytes
after:  4.292.683 bytes

@lipis lipis merged commit 11fb5ab into main Dec 11, 2023
2 checks passed
@lipis lipis deleted the svgo branch December 11, 2023 18:08
lipis added a commit that referenced this pull request Dec 11, 2023
@lipis
Merge branch 'main' of github.com:lipis/flag-icons
ba94276 
* 'main' of github.com:lipis/flag-icons:
  SVGO all files and update fill=000 to fill=000001 (#1193)
@jorrit
Copy link

jorrit commented Dec 12, 2023 •
edited
Loading

Just out of curiosity, why is #0000001 better than #000?

@lipis
Copy link
Owner Author

lipis commented Dec 12, 2023

It's not better.. but SVGO removes the default fill="#000" and it breaks some react libs.. even though I tried all the configs to disable it it would still remove it.. and we can't stop using SVGO :)

@jorrit
Copy link

jorrit commented Dec 12, 2023

I see, thanks! Would black be better, as it is shorter? Or doesn't that compress so well as #0000001?

@lipis
Copy link
Owner Author

lipis commented Dec 12, 2023

black will be removed as well by svgo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lipis @jorrit