-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix black SVG elements #1187
Fix black SVG elements #1187
Conversation
Awesome!! I can see that is still a draft.. so I'll wait until you tell me. |
I figured it would be easier to gradually do them all in this one PR, otherwise it might be hard to keep track of what's been done. If you're happy with this then I'll keep adding to this until all of them are updated. |
Sure thing! Keep going.. thanks a lot! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked the A,B flags
Checked C-E
@lipis I've gone through them all now, I don't think I missed anything. |
Awesome!! Thank you very much.. I'll check it and merge tomorrow! |
It seems that SVGO is removing this value because it's the default: gregberge/svgr#380 Hmm.. one way is to disable it is to add the Will experiment :) |
It doesn't seem to work :/ and it keeps removing the fill="#000".. maybe I'll change it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checked F-Z
Added explicit
fill="#000"
to SVG elements which should be black.So far have completed ISO codes beginning from a - e.
Fixes #1123