Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix black SVG elements #1187

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Fix black SVG elements #1187

merged 6 commits into from
Dec 5, 2023

Conversation

adamdebono
Copy link
Contributor

@adamdebono adamdebono commented Nov 27, 2023

Added explicit fill="#000" to SVG elements which should be black.

So far have completed ISO codes beginning from a - e.

Fixes #1123

@lipis
Copy link
Owner

lipis commented Nov 27, 2023

Awesome!! I can see that is still a draft.. so I'll wait until you tell me.

@adamdebono
Copy link
Contributor Author

I figured it would be easier to gradually do them all in this one PR, otherwise it might be hard to keep track of what's been done.

If you're happy with this then I'll keep adding to this until all of them are updated.

@lipis
Copy link
Owner

lipis commented Nov 27, 2023

Sure thing! Keep going.. thanks a lot!

Copy link
Contributor

@markvantilburg markvantilburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked the A,B flags
Checked C-E

@adamdebono adamdebono marked this pull request as ready for review December 3, 2023 21:48
@adamdebono
Copy link
Contributor Author

@lipis I've gone through them all now, I don't think I missed anything.

@lipis
Copy link
Owner

lipis commented Dec 3, 2023

Awesome!! Thank you very much.. I'll check it and merge tomorrow!

@lipis lipis merged commit b85ec6b into lipis:main Dec 5, 2023
2 checks passed
@lipis
Copy link
Owner

lipis commented Dec 5, 2023

It seems that SVGO is removing this value because it's the default: gregberge/svgr#380

Hmm.. one way is to disable it is to add the removeUnknownsAndDefaults https://svgo.dev/docs/plugins/remove-unknowns-and-defaults/

Will experiment :)

@lipis
Copy link
Owner

lipis commented Dec 5, 2023

It doesn't seem to work :/ and it keeps removing the fill="#000".. maybe I'll change it #000001

Copy link
Contributor

@markvantilburg markvantilburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checked F-Z

markvantilburg

This comment was marked as duplicate.

markvantilburg

This comment was marked as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black elements missing fill attribute
3 participants