fix(backfill): ingest relationships + use createdon desc during entit… #487
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
job-gms uses (urn, aspect, version, createdon) as its primary key. The current backfillEntityTables logic reads a single row from metadata_aspect and inserts it into the entity table. This normally works since the primary key of all other metadata_aspect tables is (urn, aspect, version) so it will always only have 1 result. But with job-gms, there could be multiple version 0 rows so the current logic is indeterministic on which of the possible rows it returns.
In this PR, update the query from the aspect table to order by createdon desc so that the most recently updated row is always returned in the case when there are multiple (urn, aspect, version) matches.
Also handle relationship ingestion (which was previously handled by _localAccess.add() but refactored into a separate method) during the entity table backfill.
Testing Done
update unit test for local relationships, local deployment of job-gms to confirm createdon desc query works.
Checklist