Set BasicAuth in http.go only if username and password are not empty (#914) #920

github-actions · 2022-07-13T11:50:51Z

This prevents error "read/write on closed pipe".

Go's http.client::send() always closes req.Body, so if the first request attempt
is unsuccessful, any subsequent requests after calling the CredentialsCallback
will attempt to read/write on a closed pipe.

(cherry picked from commit 9db5de1)

…914) This prevents error "read/write on closed pipe". Go's http.client::send() always closes req.Body, so if the first request attempt is unsuccessful, any subsequent requests after calling the `CredentialsCallback` will attempt to read/write on a closed pipe. (cherry picked from commit 9db5de1)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Set BasicAuth in http.go only if username and password are not empty (#914) #920

Set BasicAuth in http.go only if username and password are not empty (#914) #920

github-actions bot commented Jul 13, 2022

Set BasicAuth in http.go only if username and password are not empty (#914) #920

Are you sure you want to change the base?

Set BasicAuth in http.go only if username and password are not empty (#914) #920

Conversation

github-actions bot commented Jul 13, 2022