chore(server) Slightly Improved Linux Support #302
Conversation
| @@ -33,8 +33,21 @@ export default () => new Promise(async (resolve, reject) => { | |||
| await execa('curl', ['--version']) | |||
| log.success('"curl" found') | |||
| } else if (info.type === 'linux') { | |||
| await execa('apt-get', ['--version']) | |||
| log.success('"apt-get" found') | |||
| switch (info.distro) { | |||
There was a problem hiding this comment.
Given the number of different distributions, I think it would be easier to to just try the most popular package managers.
Maybe try something like this?
async function checkPM(name){
await execa(name, ['--version'])
return 'name'
}
let packageManager;
try {
await Promise.any([
checkPM('pacman'),
checkPM('apt-get'),
checkPM('dnf'),
])
} catch (error) {
throw new Error('Unknown package manager')
}
log.success(`${packageManager} found`)There was a problem hiding this comment.
Yeah definitely an improvement! I'll get around to fixing that, thanks. I don't suppose you had the same issue with running the test suite, what I mentioned in the PR description?
There was a problem hiding this comment.
Thanks for your contribution and your help, we appreciate it! @mattlennon3
Excuse us for the late reply.
Being able to run Leon on multiple CPU architectures, distribution, it's definitely something we would like to support, it's on the
Trello roadmap - 🔧 [1.0.0] Compatibility with ARM architectures and GNU/Linux distributions.
However, it's still something, we need to investigate to do it well :
- Where to do it: in the CLI, in the core?
- How many package managers we should support (and which ones)?
etc.
As per this comment #302 (comment), I agree that we should not support "per different distribution", but instead per the most popular package manager, as usually adding support for a Linux distribution, is a matter of using the right package manager.
There is already something, we try to do in leon-cli :
But this is not complete, and we still need to change the core to not use apt-get but be compatible with more package managers. 👍
So this is still a work in progress, and we will need to figure it out before releasing the first stable release of Leon v1.0.0.
What type of change does this PR introduce?
Does this PR introduce breaking changes?
List any relevant issue numbers:
Description:
Problems:
Related Issue:
#141 ( I would love to add fedora support but I don't know what packages are required )