-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HMR/live-reload fixes (webpack-dev-server) #7104
base: master
Are you sure you want to change the base?
Conversation
…tion while reloading, part of #6948 Signed-off-by: Roman <[email protected]>
// proxy: { | ||
// "^/$": "/build/", | ||
// }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jakolehm why do we need this proxy
at all? any ideas? it seem like works fine without this..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not very useful with stated behavior: always reloading the page and moving to Catalog. Much easier to hit Cmd+R while in Cluster view because moving back from Catalog requires "bigger effor".
Also, HMR works as expected now when changing CSS.
@aleksfront Actually I think it should do page reloading in case when HMR cannot be applied and it works fine for app's global window (e.g. it keeps latest page, /welcome, /settings) but doesn't work inside cluster iframe properly for some reasons.. Any ideas why this error happens leading to full page reload? |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
As part of #6948 since incorrectly rebased from first
monorepo
times.Current master: only manual page refresh, e.g
Cmd+R
(example of editingwelcome.tsx
)Screen.Recording.2023-02-03.at.14.31.57.mov
PR changes:
Does some auto page-reloading, but doesn't respect cluster frame location, therefore leads to updating page to global catalog page which is not desired, but better then nothing. (needs to be improved in follow up PRs)
Screen.Recording.2023-02-03.at.14.24.36.mov
Current error leading to full page reload instead of HMR (caught from video above):