-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: float_match
simproc and conv tactic
#5923
Open
nomeata
wants to merge
25
commits into
master
Choose a base branch
from
joachim/float-match
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
label
Nov 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 1, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 1, 2024
Mathlib CI status (docs):
|
leanprover-community-bot
added
the
builds-mathlib
CI has verified that Mathlib builds against this PR
label
Nov 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 2, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 4, 2024
nomeata
changed the title
feat: match_1.float theorems
feat: match_1.float theorems, simproc
Nov 4, 2024
nomeata
changed the title
feat: match_1.float theorems, simproc
feat: match floating theorems, simproc
Nov 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 4, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 4, 2024
nomeata
changed the title
feat: match floating theorems, simproc
feat: Nov 6, 2024
float_match
simproc and conv tactic
nomeata
commented
Nov 6, 2024
leanprover-community-mathlib4-bot
added a commit
to leanprover-community/batteries
that referenced
this pull request
Nov 12, 2024
nomeata
added
the
changelog-language
Language features, tactics, and metaprograms
label
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
builds-mathlib
CI has verified that Mathlib builds against this PR
changelog-language
Language features, tactics, and metaprograms
toolchain-available
A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
float_match
simproc and conv tactic.This adds the ability float matches “up” (or equivalently push context into matches): For example, this allows to rewrite
to
One motivation are proofs like the following, where we are pushing a function (here,
map f
) “down” through another function, and that should be provable just by rewriting, without usingsplit
:This adds
foo.match_1.float
, a (lazily realizable) theorem for each matcher that performs the rewrite above for an arbitraryf
float_match
simprocfloat_match
conv tacticFor the purpose of these simprocs and tactics,
ite
anddite
are considered a matcher.The
simproc
only floats out through one function at a time, and only intoType
context, notProp
-context. This is to prevent the writewhich is not wrong and may sometimes actually work, but in order to be useful reliably this would require more work (in particular strong contextual congruence rules for matchers that in particular allow to rewrite match statements inside the alts). The
conv
tactic does not have this restriction.This is inspired by the “splitter” in Isabelle’s simplifier (https://stackoverflow.com/a/47124021/946226).