Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Istio Crypto Scheduled Workflow #79
base: master
Are you sure you want to change the base?
Istio Crypto Scheduled Workflow #79
Changes from 2 commits
2e338d2
43791af
1311093
2df0a0f
79fbbe9
69f382f
ddc266a
9f67fc4
355fa95
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asubedy For crypto test case, the
GATEWAY_URL
should behttps://$INGRESS_HOST:$SECURE_INGRESS_PORT
.And we need to generate a self-signed certificate to use in performance profile, so we can create another shell script which can be named as
generate_csr.sh
, I can provide the script we used before:Then we can use the URL and
fortio.com.crt
in performance file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gyohuangxin I created the file, so we run this script after deploying Istio Crypto and deploying httpbin application right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asubedy Yes, it's correct.