-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix scheduled builds #36
Conversation
// @hershd23 |
Thank you, @AugustasV! 👍 |
@AugustasV Thank you, and this code looks good to me. But a little suggestion, could you rebase your 5 commits to one commit, because they are doing the same thing, which will help keep commit log clean. |
Hi @AugustasV great work and thank you for taking up this problem. Just a couple of suggestions :-
Edit :- @AugustasV I have done point 2 for you here, do confirm it for me though I believe after this your changes would be ready to merge |
Signed-off-by: AugustasV <[email protected]>
Thank you for suggestions and tips, squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The PR was linked to the wrong issue. Removed that from the PR description.
LGTM.
Description
Notes for Reviewers
Was looking into this issue why builds been failing, find out that Open Service Mesh (OSM) CLI version was changed, also tried to simplify code to see what can I do to make it work.
Unsuccessful run on master here :- https://github.com/layer5io/meshery-smp-action/runs/5204098138?check_suite_focus=true
Successful run on your local fork :- https://github.com/AugustasV/meshery-smp-action/runs/5204058656?check_suite_focus=true
Signed commits