-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed <img> to gatsby-plugin-image to improve performance #5995
Conversation
🚀 Preview for commit 807b63d at: https://6708100b21b1093b3d602bac--layer5.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is helpful. +1
@yaten2302 Thank you for this. LGTM |
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
1 similar comment
🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address). To amend the commits in this PR with your signoff using the instructions provided in the DCO check. To configure your dev environment to automatically signoff on your commits in the future, see these instructions.
|
@yaten2302 the Meshery logo being cut off |
🚀 Preview for commit 3818cd3 at: https://670ad9d66e5649874caf9bb8--layer5.netlify.app |
@yaten2302 the css previously applied to the |
🚀 Preview for commit 84213cb at: https://670cb5b6768ef85b3e210065--layer5.netlify.app |
@Touriist , I was checking about the styles applied to the Also, I recently pulled some changes from the main repo, actually, this error is being shown to me, are you also getting this, or should I re clone this repo? |
@yaten2302 Please add it as an agenda item to the meeting minutes. |
@vishalvivekm , ig this issue is already added in the meeting minutes 👍 |
@vishalvivekm @Touriist , there's some issue with this PR, I'm closing this, will create a new PR soon👍 |
Description
Fixes #5842
This PR fixes #5824
This PR changes all the images of this section in this link, and replaces
<img />
tag with<StaticImage />
Notes for Reviewers
Signed commits