Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed <img> to gatsby-plugin-image to improve performance #5995

Closed
wants to merge 3 commits into from

Conversation

yaten2302
Copy link
Contributor

@yaten2302 yaten2302 commented Oct 10, 2024

Description

Fixes #5842

This PR fixes #5824

This PR changes all the images of this section in this link, and replaces <img /> tag with <StaticImage />

image

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

@l5io
Copy link
Contributor

l5io commented Oct 10, 2024

🚀 Preview for commit 807b63d at: https://6708100b21b1093b3d602bac--layer5.netlify.app

Copy link

@miacycle miacycle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful. +1

@Touriist
Copy link
Contributor

@yaten2302 Thank you for this. LGTM
Can you refer to the correct issue for this PR, if there's one ?

Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

1 similar comment
Copy link

🚨 Alert! Git Police! We couldn’t help but notice that one or more of your commits is missing a sign-off. A what? A commit sign-off (your email address).

To amend the commits in this PR with your signoff using the instructions provided in the DCO check.

To configure your dev environment to automatically signoff on your commits in the future, see these instructions.


        Be sure to join the community, if you haven't yet and please leave a ⭐ star on the project 😄

@Touriist
Copy link
Contributor

@yaten2302 the Meshery logo being cut off
Screen Shot 2024-10-13 at 01 50 24

@l5io
Copy link
Contributor

l5io commented Oct 12, 2024

🚀 Preview for commit 3818cd3 at: https://670ad9d66e5649874caf9bb8--layer5.netlify.app

@yaten2302
Copy link
Contributor Author

yaten2302 commented Oct 13, 2024

@Touriist , this PR fixes #5842 issue

Also, I copied the meshery logo from the file path which was earlier being used to render the image. Could you please guide that is this the wrong image which I'm using?

@Touriist
Copy link
Contributor

@Touriist , this PR fixes #5842 issue

Also, I copied the meshery logo from the file path which was earlier being used to render the image. Could you please guide that is this the wrong image which I'm using?

@yaten2302 the css previously applied to the <img> element might not be properly applied to the <StaticImage> component. We'll have to ensure existing styles target the image inside StaticImage correctly

@l5io
Copy link
Contributor

l5io commented Oct 14, 2024

🚀 Preview for commit 84213cb at: https://670cb5b6768ef85b3e210065--layer5.netlify.app

@yaten2302
Copy link
Contributor Author

@Touriist , I was checking about the styles applied to the <img /> tag. But, ig, I haven't removed the tags in my commit, I'm checking if there's any other error here :/

Also, I recently pulled some changes from the main repo, actually, this error is being shown to me, are you also getting this, or should I re clone this repo?

image


image

@vishalvivekm
Copy link
Member

@yaten2302
Let's discuss this during the website call on Monday at 5:30 PM IST (7:00 AM CT).

Please add it as an agenda item to the meeting minutes.

@yaten2302
Copy link
Contributor Author

@vishalvivekm , ig this issue is already added in the meeting minutes 👍
We'll surely discuss about it today 👍

@yaten2302
Copy link
Contributor Author

@vishalvivekm @Touriist , there's some issue with this PR, I'm closing this, will create a new PR soon👍

@yaten2302 yaten2302 closed this Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

[Performance] Use gatsby-plugin-image component instead of <img> tag
5 participants