Skip to content

Commit

Permalink
Merge pull request #193 from lana/fix-empty-href-button-link
Browse files Browse the repository at this point in the history
Fix empty href on button link behavior
  • Loading branch information
José Ortiz authored Mar 9, 2022
2 parents 9a15c99 + a465ea3 commit f7e1cc5
Show file tree
Hide file tree
Showing 4 changed files with 16 additions and 13 deletions.
18 changes: 9 additions & 9 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@lana/b2c-mapp-ui",
"version": "9.6.1",
"version": "9.6.2",
"description": "Shared custom libraries for building µapps.",
"bugs": {
"url": "https://github.com/lana/b2c-mapp-ui/issues"
Expand Down Expand Up @@ -48,7 +48,7 @@
"dist/*"
],
"dependencies": {
"@lana/b2c-mapp-ui-assets": "^5.14.0",
"@lana/b2c-mapp-ui-assets": "^5.19.0",
"libphonenumber-js": "^1.9.47",
"lodash-es": "^4.17.21",
"vue": "^3.2.21",
Expand Down
5 changes: 4 additions & 1 deletion src/components/Button/Button.stories.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@ const ButtonStories = {
dropShadow: false,
debounce: false,
debounceDelay: 400,
href: '',
href: undefined,
link: false,
loadingText: 'Cargando...',
default: 'Example Button',
},
Expand All @@ -34,6 +35,7 @@ const ButtonStories = {
debounce: { name: 'Has debounce?', control: 'boolean' },
debounceDelay: { name: 'Debounce Delay', control: { type: 'number', step: 100 } },
href: { name: 'href', control: 'text' },
link: { name: 'Is link?', control: 'boolean' },
loadingText: { name: 'Loading Text', control: 'text' },
default: {
control: {
Expand Down Expand Up @@ -67,6 +69,7 @@ const defaultExample: StoryFn<typeof Button> = (args, { argTypes }) => ({
<div style="margin: 20px;">
<Button :type="type"
:href="href"
:link="link"
:loading="loading"
:loading-text="loadingText"
:drop-shadow="dropShadow"
Expand Down
2 changes: 1 addition & 1 deletion src/components/Button/Button.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const Button = defineComponent({
},
href: {
type: String,
default: '',
default: undefined,
},
link: Boolean,
loading: Boolean,
Expand Down

0 comments on commit f7e1cc5

Please sign in to comment.