Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

secrets-store-sync-controller - Add prow test jobs for release #33439

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

secrets-store-sync-controller - Add prow test jobs for release #33439

wants to merge 3 commits into from

Conversation

omerap12
Copy link
Member

@omerap12 omerap12 commented Sep 7, 2024

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @omerap12. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the area/config Issues or PRs related to code in /config label Sep 7, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: omerap12
Once this PR has been reviewed and has the lgtm label, please assign aramase for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 7, 2024
@omerap12
Copy link
Member Author

omerap12 commented Sep 7, 2024

cc @aramase @nilekhc

@krzyzacy
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 17, 2024
@omerap12 omerap12 force-pushed the release-secrets-store-sync-controller branch from ba619a7 to e924e14 Compare September 24, 2024 06:23
nilekhc
nilekhc suggested changes Oct 7, 2024
View reviewed changes
...jobs/kubernetes-sigs/secrets-store-sync-controller/secrets-store-sync-controller-config.yaml Outdated
@@ -268,7 +268,178 @@ presubmits:
testgrid-tab-name: pr-secrets-store-sync-controller-e2e-provider-k8s-1-31-0
description: "Run e2e tests with e2e-provider for Secrets Store Sync Controller on Kubernetes 1.31.0"
testgrid-num-columns-recent: '30'

- name: release-secrets-store-sync-controller-e2e-provider-k8s-1-27-15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like jobs are not updated with right k8s versions yet. We are currently using 1.28.13, 1.29.8, 1.30.4, 1.31.0

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make changes in all the release jobs

...jobs/kubernetes-sigs/secrets-store-sync-controller/secrets-store-sync-controller-config.yaml Outdated
cpu: "4"
memory: "8Gi"
annotations:
testgrid-dashboards: sig-auth-secrets-store-sync-controller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add release-signal dashboard similar to -

test-infra/config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml

Line 636 in 7b0acf3

testgrid-dashboards: sig-auth-secrets-store-csi-driver, sig-auth-secrets-store-csi-driver-release-signal

@omerap12 omerap12 requested a review from nilekhc October 7, 2024 17:52
@omerap12
Copy link
Member Author

omerap12 commented Nov 9, 2024

/retest

@k8s-ci-robot
Copy link
Contributor

@omerap12: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-unit-test 85e63f0 link true /test pull-test-infra-unit-test
pull-test-infra-unit-test-race-detector-nonblocking 85e63f0 link false /test pull-test-infra-unit-test-race-detector-nonblocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

krzyzacy
krzyzacy suggested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@krzyzacy krzyzacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this is a new dashboard and you will also need to update https://github.com/kubernetes/test-infra/blob/master/config/testgrids/config.yaml#L79-L87

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krzyzacy krzyzacy krzyzacy requested changes

@aramase aramase Awaiting requested review from aramase

@nilekhc nilekhc Awaiting requested review from nilekhc

Assignees

@krzyzacy krzyzacy

@nilekhc nilekhc

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@omerap12 @k8s-ci-robot @krzyzacy @nilekhc