-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove cloud-provider-azure push-images #33047
base: master
Are you sure you want to change the base?
Conversation
|
efdecf1
to
990d88e
Compare
@dims shall we remove this file? Thanks |
@dims @BenTheElder could you help to sign-off? |
990d88e
to
6fbfcaa
Compare
Uh, this is the opposite direction of how we've been trying to setup the project to not depend on infrastructure only members at a single company can access? can we not do this? |
Ideally, if no one at Microsoft is focused on this project at some point, other people can still contribute and step up to maintain it, even for a vendor integration project. That's more difficult if we have dependencies on accounts that aren't provided by the project in areas like test and releasing. |
/hold |
I have to echo what @BenTheElder said. All projects living under the Kubernetes umbrella, i.e. in the Kubernetes GitHub organizations, should use the community infrastructure for their purposes, unless instructed otherwise by SIG K8s Infra. We did some very hard job to migrate away from the company-specific infrastructure that we have zero access to and zero insights into, let's not go backwards again. We very welcome projects and companies to mirror images to their registries and use those mirrored images for their platforms/products/customers, but the authoritative source should always be hosted on the community infrastructure. |
Also, let's not forget the situation that we had with vSphere-related projects just a couple of weeks ago, where the registry simply went missing: kubernetes-sigs/vsphere-csi-driver#3053 We want to make sure that we can avoid such situations, and the only way we can do that is by ensuring we have (some) control over the infrastructure. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lzhecheng, timwangmusic The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase
Hello @timwangmusic , I saw other owners are talking about that such images should be managed by community. Do you reach an agreement on deletion? Because @dims is still holding this PR. |
Read the comments and I concur with the other owners on holding the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hold on discussion
The image is already in MCR, so there's no need for this. Signed-off-by: Zhecheng Li <[email protected]>
6fbfcaa
to
7c5b1b2
Compare
New changes are detected. LGTM label has been removed. |
@lzhecheng: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
The image is already in MCR, so there's no need for this.