Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cloud-provider-azure push-images #33047

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lzhecheng
Copy link
Contributor

The image is already in MCR, so there's no need for this.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 22, 2024
@lzhecheng
Copy link
Contributor Author

cloud-controller-manager and cloud-node-manager images are already hosted in MCR. It doesn't seem to be necessary here.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 27, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 15, 2024
@lzhecheng
Copy link
Contributor Author

@dims shall we remove this file? Thanks

@feiskyer
Copy link
Member

@dims @BenTheElder could you help to sign-off?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 11, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 10, 2024
@BenTheElder
Copy link
Member

Uh, this is the opposite direction of how we've been trying to setup the project to not depend on infrastructure only members at a single company can access?

can we not do this?

@BenTheElder
Copy link
Member

Ideally, if no one at Microsoft is focused on this project at some point, other people can still contribute and step up to maintain it, even for a vendor integration project. That's more difficult if we have dependencies on accounts that aren't provided by the project in areas like test and releasing.

@dims
Copy link
Member

dims commented Oct 10, 2024

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 10, 2024
@xmudrii
Copy link
Member

xmudrii commented Oct 10, 2024

I have to echo what @BenTheElder said. All projects living under the Kubernetes umbrella, i.e. in the Kubernetes GitHub organizations, should use the community infrastructure for their purposes, unless instructed otherwise by SIG K8s Infra. We did some very hard job to migrate away from the company-specific infrastructure that we have zero access to and zero insights into, let's not go backwards again.

We very welcome projects and companies to mirror images to their registries and use those mirrored images for their platforms/products/customers, but the authoritative source should always be hosted on the community infrastructure.

@xmudrii
Copy link
Member

xmudrii commented Oct 10, 2024

Also, let's not forget the situation that we had with vSphere-related projects just a couple of weeks ago, where the registry simply went missing: kubernetes-sigs/vsphere-csi-driver#3053

We want to make sure that we can avoid such situations, and the only way we can do that is by ensuring we have (some) control over the infrastructure.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 12, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 12, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lzhecheng, timwangmusic

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 12, 2024
Copy link
Contributor

@timwangmusic timwangmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase

@lzhecheng
Copy link
Contributor Author

Hello @timwangmusic , I saw other owners are talking about that such images should be managed by community. Do you reach an agreement on deletion? Because @dims is still holding this PR.

@timwangmusic
Copy link
Contributor

Hello @timwangmusic , I saw other owners are talking about that such images should be managed by community. Do you reach an agreement on deletion? Because @dims is still holding this PR.

Read the comments and I concur with the other owners on holding the PR.

Copy link
Contributor

@timwangmusic timwangmusic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on discussion

The image is already in MCR, so there's no need for this.

Signed-off-by: Zhecheng Li <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 17, 2024
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 17, 2024
@k8s-ci-robot
Copy link
Contributor

@lzhecheng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-verify-lint 7c5b1b2 link true /test pull-test-infra-verify-lint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants