Fastly: fix the cache rule for the version markers. #7518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related: - kubernetes#7447 We do not capture the latest-1.txt and stable-1.txt due to the regex rule define for all the version markers.
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
added
area/infra
|
/hold Not exactly sure about this regex rule. how to test it: echo "151.101.0.204 cdn.dl-sandbox.k8s.dev" > /etc/hosts
curl -vvv -H "fastly-debug:1" http://cdn.dl-sandbox.k8s.dev/release/latest-1.txtA cc @BenTheElder |
k8s-ci-robot
added
the
do-not-merge/hold
BenTheElder
reviewed
Nov 14, 2024
| @@ -45,7 +45,7 @@ sub vcl_fetch { | |||
| } | |||
|
|
|||
| # Ensure version markers are not cached at the edge | |||
| if (req.url.path ~ "^/release/(latest|stable)(-\d+(\.\d+))?\.txt\z") { | |||
| if (req.url.path ~ "^/release/(latest|stable)(-\d+(\.\d+)?)?\.txt\z") { | |||
There was a problem hiding this comment.
Why don't we do:
Suggested change
| if (req.url.path ~ "^/release/(latest|stable)(-\d+(\.\d+)?)?\.txt\z") { | |
| if (req.url.path ~ "^/release/(latest|stable)([^/]*)\.txt\z") { |
So any top level release file that starts with latest or stable, ends with .txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
We do not capture the latest-1.txt and stable-1.txt due to the regex
rule define for all the version markers.