Fastly: Include security headers for dl #7278
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
k8s-ci-robot
added
the
size/S
BenTheElder
reviewed
Sep 10, 2024
|
Yes but IMHO it doesn't hurt to have them. We don't know if in the future for examples static pages we host will be become dynamic content. |
sftim
reviewed
Nov 14, 2024
| set resp.http.Referrer-Policy = "origin-when-cross-origin"; | ||
|
|
||
| if (req.protocol == "https") { | ||
| set resp.http.Strict-Transport-Security = "max-age=63072000; includeSubDomains"; |
There was a problem hiding this comment.
Could add a comment about how we picked the max age.
sftim
reviewed
Nov 14, 2024
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
Related: - kubernetes#7447 We do not capture the latest-1.txt and stable-1.txt due to the regex rule define for all the version markers.
Add Security headers to the VCL service. Ref: - https://web.dev/secure/ - https://infosec.mozilla.org/guidelines/web_security Signed-off-by: Arnaud Meukam <[email protected]>
ameukam
force-pushed
the
fastly-security-headers
branch
from
52075aa
to
17c3fe5
Compare
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Security headers to the VCL service.
Ref: