-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: nginx proxy server list not changed #12034
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chengjoey The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @chengjoey. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-ingress-nginx canceled.
|
cd9c959
to
2617d2f
Compare
/hold We are going to deprecate TLS Passthrough on the next release, I wouldn't like to touch this for now. |
What would be the alternative? |
Signed-off-by: joey <[email protected]>
2617d2f
to
acaba8b
Compare
We're not going to deprecate this in the next few releases or add new functionality. This functionality will be migrated to the appropriate place in our gateway api implementation. |
What this PR does / why we need it:
The logic of updating the proxy server list seems to be unrelated to
generateTemplate
. Ifssl-passthrough
is enabled but the config has not changed, the proxy server list will not be updated. However, the service corresponding to passthrough may have changed. Therefore, the logic of updating the server list should be placed before onUpdate.Types of changes
Which issue/s this PR fixes
fixes #11963
How Has This Been Tested?
Checklist: