-
Notifications
You must be signed in to change notification settings - Fork 610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update openstack-cinder-csi helm chart for multi cloud support #2681
base: master
Are you sure you want to change the base?
Update openstack-cinder-csi helm chart for multi cloud support #2681
Conversation
…trollerPlugin + documentation
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @guillaumebernard84. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Hello, this PR modifies the openstack-cinder-csi helm chart to allow to use it with the multi cloud feature: #2551
It fixes two problems that were preventing to use the chart with multi cloud:
extraArgs
on thecinder-csi-plugin
containers of the deployment and the daemonset. It wasn't possible with the current version. Now you can, like this:You still need to create the second daemonset manually, but at least you can use the chart. If this PR is accepted, I'll work on a new one to allow the creation of the second daemonset.
resizer
and thesnapshotter
, you will need them to be able to read the secrets you defined in the storage class' annotations in order to determine which cloud to address. This was hardcoded in controllerplugin-rbac.yaml, now you can specify it like this:I also moved the comments from controllerplugin-rbac.yaml to the values file.
I added these info to the multi-region-clouds.md documentation file.