Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated link for glossary.md #5765

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated link for glossary.md #5765

wants to merge 1 commit into from
+9 −9

Conversation

kundan2707
Copy link
Contributor

Corrected link for glossary.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: kundan2707
Once this PR has been reviewed and has the lgtm label, please assign varshaprasad96 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 17, 2024
@kundan2707
Copy link
Contributor Author

/kind documentation
fixes: #5753

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 17, 2024
koba1t
koba1t reviewed Sep 18, 2024
View reviewed changes
examples/ldap/README.md Outdated
@@ -1,4 +1,4 @@
[base]: ../../docs/glossary.md#base
[base]: ../../docs/Reference/glossary.md#base
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opened the link and got a 404. Did you want to refer to either of the links below?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

corrected multiple links and pushed again

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 19, 2024
koba1t
koba1t reviewed Sep 19, 2024
View reviewed changes
examples/validationTransformer/README.md
[kubeval]: https://github.com/instrumenta/kubeval
[plugin]: ../../docs/plugins
[plugin]: ../../plugins
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the right link is here https://github.com/kubernetes-sigs/kustomize/tree/master/plugin

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koba1t I will put this link and update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koba1t koba1t koba1t left review comments

@ncapps ncapps Awaiting requested review from ncapps

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kundan2707 @k8s-ci-robot @koba1t