Use QueueNameForObject in Deployment Webhook. #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: mbobrovskyi The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
size/M
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
mbobrovskyi
force-pushed
the
cleanup/use-ValidateImmutableField-on-deployment-webhook
branch
2 times, most recently
from
95dfc45
to
7c8af61
Compare
mbobrovskyi
force-pushed
the
cleanup/use-ValidateImmutableField-on-deployment-webhook
branch
from
7c8af61
to
03603ee
Compare
mbobrovskyi
changed the title
|
/cc @mimowo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Use QueueNameForObject in Deployment Webhook to validate both QueueName Label and QueueName Annotation.
Which issue(s) this PR fixes:
Prepare for #3555
Special notes for your reviewer:
Does this PR introduce a user-facing change?