Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAS: cleanup TopologyUngater to prepare for ranks support #3532

Merged
merged 2 commits into from
Nov 15, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Nov 14, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To prepare for the support for ranks.

Which issue(s) this PR fixes:

Part of #3533
Part of #3450

Special notes for your reviewer:

Here I split the podsetPodsToUngate function into 3 phases:

  • listing the pods by podsForPodSet
  • assignGatedPodsToDomains assigns gated pods to domains (for pods which are going to be ungated)
  • podsToUngateInfo - translates the domainID information into node selectors for each pod to ungate

This allows to reuse easily the code for podsForPodSet and podsToUngateInfo in case of rank ordering.
The ideas is to split assignGatedPodsToDomains into two: assignGatedPodsToDomainsGreedy ( current), or assignGatedPodsToDomainsWithRanks (when ranks are available), but this will be follow up.

The follow up is WIP: #3539 - I added the bbec763 commit to make this PR consistent with the follow up and minimize future diff.

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 14, 2024
Copy link

netlify bot commented Nov 14, 2024

Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit bbec763
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/6736f7b8be87b20008699069

@mimowo
Copy link
Contributor Author

mimowo commented Nov 14, 2024

/assign @PBundyra
cc @tenzen-y @gabesaba

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Nov 15, 2024

FYI, I have noticed I don't need receiver for some of the functions and so I added another commit bbec763, which is already aligned with the WIP follow up to support for Job: #3539

@PBundyra
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0c92023e4b0787730aea4b74704d0a8e337d274a

@k8s-ci-robot k8s-ci-robot merged commit a90686e into kubernetes-sigs:main Nov 15, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants