generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TAS: cleanup TopologyUngater to prepare for ranks support #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
Denotes a PR that doesn't merit a release note.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
labels
Nov 14, 2024
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 14, 2024
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
mimowo
force-pushed
the
tas-pod-ranks
branch
from
November 14, 2024 14:31
2332158
to
24509a4
Compare
k8s-ci-robot
added
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
and removed
size/M
Denotes a PR that changes 30-99 lines, ignoring generated files.
labels
Nov 15, 2024
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Nov 15, 2024
LGTM label has been added. Git tree hash: 0c92023e4b0787730aea4b74704d0a8e337d274a
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
kind/cleanup
Categorizes issue or PR as related to cleaning up code, process, or technical debt.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
release-note-none
Denotes a PR that doesn't merit a release note.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
To prepare for the support for ranks.
Which issue(s) this PR fixes:
Part of #3533
Part of #3450
Special notes for your reviewer:
Here I split the
podsetPodsToUngate
function into 3 phases:podsForPodSet
assignGatedPodsToDomains
assigns gated pods to domains (for pods which are going to be ungated)podsToUngateInfo
- translates the domainID information into node selectors for each pod to ungateThis allows to reuse easily the code for
podsForPodSet
andpodsToUngateInfo
in case of rank ordering.The ideas is to split
assignGatedPodsToDomains
into two:assignGatedPodsToDomainsGreedy
( current), orassignGatedPodsToDomainsWithRanks
(when ranks are available), but this will be follow up.The follow up is WIP: #3539 - I added the bbec763 commit to make this PR consistent with the follow up and minimize future diff.
Does this PR introduce a user-facing change?