Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kjobctl] Add slurm-init image. #3269

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mbobrovskyi
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Add slurm-init image for kjob.

Which issue(s) this PR fixes:

Part of #3243

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 21, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbobrovskyi
Once this PR has been reviewed and has the lgtm label, please assign trasc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 21, 2024
Copy link

netlify bot commented Oct 21, 2024

Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 1cbd302
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/67344044d50c0000087813fa
😎 Deploy Preview https://deploy-preview-3269--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mbobrovskyi
Copy link
Contributor Author

/cc @mimowo

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's make this something like cmd/experimental/kjobctl/cmd/slurm-init/Dockerfile,

I think it's better in the long run to have a go app doing the init setup. (we can make the image smaller)

cmd/experimental/kjobctl/Makefile Outdated Show resolved Hide resolved
@mbobrovskyi mbobrovskyi marked this pull request as draft October 22, 2024 04:25
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kjob-slurm-init-container branch 2 times, most recently from b067b76 to 53546bf Compare October 24, 2024 08:10
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 24, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kjob-slurm-init-container branch from 53546bf to 1d73998 Compare October 25, 2024 12:07
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 25, 2024
@mbobrovskyi mbobrovskyi force-pushed the feature/kjob-slurm-init-container branch from 1d73998 to 1cbd302 Compare November 13, 2024 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants