Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSPP: Implementation of Heterogeneous Multi-Edge Collaborative Neural Network Inference for High Mobility Scenarios #151

Merged
merged 1 commit into from
Oct 29, 2024
Merged

OSPP: Implementation of Heterogeneous Multi-Edge Collaborative Neural Network Inference for High Mobility Scenarios #151

merged 1 commit into from
Oct 29, 2024

Conversation

wyoung1
Copy link
Contributor

@wyoung1 wyoung1 commented Sep 25, 2024

This PR is implementaion of #100

@kubeedge-bot kubeedge-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 25, 2024
@MooreZheng MooreZheng requested review from hsj576 and removed request for Poorunga September 26, 2024 08:43
MooreZheng
MooreZheng requested changes Oct 14, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are CI issues that remain to be resolved, see https://github.com/kubeedge/ianvs/actions/runs/11074859852?pr=151

@MooreZheng
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@MooreZheng
Copy link
Collaborator

@hsj576 might also want to take a look at this project implementation

@yunzhe99
Copy link

/lgtm

@kubeedge-bot
Copy link
Collaborator

@yunzhe99: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hsj576
hsj576 approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@hsj576 hsj576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@MooreZheng MooreZheng added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 26, 2024
MooreZheng
MooreZheng reviewed Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request contains 4 commits, which might make maintenance difficult, considering the number of contributors, pull requests, and their commits in KubeEdge Ianvs recently. In the final stage, @wyoung1 can squash the commits into one using rebase techniques.

@wyoung1
coding for ospp
e87b047 
Signed-off-by: wyoung1 <[email protected]>

fix pylint

Signed-off-by: wyoung1 <[email protected]>

fix pylint issue

Signed-off-by: wyoung1 <[email protected]>
@kubeedge-bot kubeedge-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@wyoung1
Copy link
Contributor Author

wyoung1 commented Oct 28, 2024

This pull request contains 4 commits, which might make maintenance difficult, considering the number of contributors, pull requests, and their commits in KubeEdge Ianvs recently. In the final stage, @wyoung1 can squash the commits into one using rebase techniques.

Thank you for your suggestion, I have squashed all submissions into one.

@MooreZheng
Copy link
Collaborator

/lgtm

@kubeedge-bot kubeedge-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 28, 2024
@hsj576
Copy link
Member

hsj576 commented Oct 28, 2024

/lgtm

@yunzhe99
Copy link

lgtm

@MooreZheng
Copy link
Collaborator

/approve

@kubeedge-bot kubeedge-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2024
@kubeedge-bot kubeedge-bot merged commit 29d456b into kubeedge:main Oct 29, 2024
13 checks passed
MooreZheng
MooreZheng approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@MooreZheng MooreZheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All concerns are fixed. Well done @wyoung1

@kubeedge-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hsj576, MooreZheng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsj576 hsj576 hsj576 approved these changes

@MooreZheng MooreZheng MooreZheng approved these changes

Assignees

@MooreZheng MooreZheng

@yunzhe99 yunzhe99

@hsj576 hsj576

@wyoung1 wyoung1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wyoung1 @MooreZheng @yunzhe99 @kubeedge-bot @hsj576