[Course Certification Task] Add raspi4b Support and a web app to control. #129
Conversation
Signed-off-by: xingleigao <[email protected]>
Signed-off-by: xingleigao <[email protected]>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubeedge-bot
added
the
size/XXL
|
/assign |
| metadata: | ||
| labels: | ||
| k8s-app: kubeedge-counter-app | ||
| name: kubeedge-counter-app |
There was a problem hiding this comment.
the name of this deployment could be changed to kubeedge-light-app or something
There was a problem hiding this comment.
the name of this deployment could be changed to kubeedge-light-app or something
please modify thenameandlabel. they are stillkubeedge-counter-app
| go build -o kubeedge-counter-controller main.go | ||
|
|
||
| docker: | ||
| docker build . -t kubeedge/kubeedge-counter-app:v1.0.0 |
There was a problem hiding this comment.
the name of this image could be changed to kubeedge-light-app or something
| Status devices.DeviceStatus `json:"status"` | ||
| } | ||
|
|
||
| // The device id of the counter |
There was a problem hiding this comment.
replace 'counter' with 'light' across this file
|
please remove the binary of |
|
please move all the deployment yaml files of |
Signed-off-by: xingleigao <[email protected]>
|
Hi, I have fixed all issue. Please check again. |
kubeedge-bot
added
the
do-not-merge/work-in-progress
kubeedge-bot
removed
the
do-not-merge/work-in-progress
|
@RyanZhaoXB please have a look. |
| metadata: | ||
| labels: | ||
| k8s-app: kubeedge-counter-app | ||
| name: kubeedge-counter-app |
There was a problem hiding this comment.
the name of this deployment could be changed to kubeedge-light-app or something
please modify thenameandlabel. they are stillkubeedge-counter-app
|
|
||
| "github.com/kubeedge/examples/kubeedge-counter-demo/web-controller-app/utils" | ||
| devices "github.com/kubeedge/kubeedge/cloud/pkg/apis/devices/v1alpha2" | ||
|
|
There was a problem hiding this comment.
please delete the blank lines of the import package and reorder the packages
|
|
||
| import ( | ||
| "github.com/astaxie/beego" | ||
| controllers "github.com/kubeedge/examples/kubeedge-counter-demo/web-controller-app/controller" |
There was a problem hiding this comment.
maybe it should be importing github.com/kubeedge/examples/led-raspberrypi/web-controller-app/controller
| "encoding/json" | ||
| "log" | ||
|
|
||
| "github.com/kubeedge/examples/kubeedge-counter-demo/web-controller-app/utils" |
There was a problem hiding this comment.
maybe it should be importing github.com/kubeedge/examples/led-raspberrypi/web-controller-app/utils
| COPY views /views | ||
|
|
||
| # Define default command | ||
| ENTRYPOINT ["/kubeedge-counter-controller"] |
There was a problem hiding this comment.
it should be /kubeedge-light-controller
| ENTRYPOINT ["/kubeedge-counter-controller"] | ||
|
|
||
| # Run the executable | ||
| CMD ["kubeedge-counter-controller"] |
| # Based on ubuntu | ||
| FROM ubuntu:latest | ||
| LABEL maintainers="KubeEdge Community Developer" | ||
| LABEL description="KubeEdge Counter Web Controller App" |
| @@ -1,50 +0,0 @@ | |||
| # github.com/eclipse/paho.mqtt.golang v1.2.0 | |||
There was a problem hiding this comment.
im thinking that maybe we should remove all the vendor and use gomod mode. do you agree?
Signed-off-by: xingleigao <[email protected]>
|
All has chenged. I agree with "remove all the vendor and use gomod", and I do that. Please have a look agin, thank you!@RyanZhaoXB |
xingleigao
changed the title
There is twice commmit.
And I update ReadMe adn some images to that.