Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose idleReplicaCount param to httpScaledObject #594

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lucakuendig
Copy link
Contributor

@lucakuendig lucakuendig commented Jan 31, 2023

Signed-off-by: Luca Kuendig [email protected]

I added spec.replicas.idle which allows to pass a value for spec.idleReplicaCount to the generated ScaledObject. We need this to work for our current use-case.

Pls tell me if I need to update any docs. On first glance I could not find anything that would need an update.

Checklist

Fixes #

Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you update the changelog please?

@JorTurFer
Copy link
Member

JorTurFer commented Feb 10, 2023

hello @lucakuendig
Could you also rebase the branch? 🙏 The fix for the failing links CI is already merged

@JorTurFer
Copy link
Member

Hello, any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants