-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for tracing for http addon #1021
base: main
Are you sure you want to change the base?
feat: Add support for tracing for http addon #1021
Conversation
f945b23
to
1eb19da
Compare
f64c6dc
to
480050e
Compare
c95f18e
to
eb64c18
Compare
@bhussain91 any update on this please? |
eb64c18
to
b093281
Compare
@zroubalik I've refactored the code as per comments by @JorTurFer |
8075523
to
91702b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhussain91 could you please fix the linter problem?
91702b3
to
444c2b5
Compare
@zroubalik |
444c2b5
to
4d127f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bhussain91 could you please fix conflicts in go.mod? 🙏
4d127f0
to
1dc7d39
Compare
@zroubalik conflicts should be resolved now :) thanks |
1dc7d39
to
cb53f12
Compare
@zroubalik @JorTurFer wondering why the e2e tests are failing here? whereas they seem to pass when I execute them locally. is there something I need to do? |
The only test that's failing is |
actually I've made some code changes, realised it was failing on my local again due to schema version conflict which should be resolved now, local e2e-tests are passing now on a brand new cluster with no test caches |
dd98d3c
to
f23ed8f
Compare
great, there are some problems in the static check, PTAL |
|
@bhussain91 let's ingore the whitesource, it is failing across the whole org, not related to this PR
It is an env issue, not related to this PR, please disregard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (sorry for the super late review, my life's been complicated). Could you rebase main branch to fix go.mod/go.sum issues?
Signed-off-by: Bilal Hussain <[email protected]>
f23ed8f
to
4ad9caf
Compare
Hey sorry was away on holiday, I've rebased now, should be all up to date |
Sorry because we were on vacations this time :( could you rebase your branch again? Now we are here to merge it |
Signed-off-by: Bilal Hussain [email protected]
Provide a description of what has been changed
The change is to add tracing capability into the keda http addon using opentelemetry. The changes allows the add on to generate and export spans to console (development) or otel gRPC endpoint. Further information on how to configure tracing can be found in the docs
Checklist
README.md
docs/
directoryFixes #