Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(router): add core changes for external authentication flow through unified_authentication_service #7063

Open
wants to merge 9 commits into
base: 7862-refactor-refactor-ctp-flow-to-fetch-mca_id-and-get-the-connector-creds-instead-of-connector_name
Choose a base branch
from

Conversation

sai-harsha-vardhan
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

add core changes for external authentication flow through unified_authentication_service

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Compiler guided - Core changes alone done, can be tested after connector related changes are done

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@sai-harsha-vardhan sai-harsha-vardhan added A-core Area: Core flows C-feature Category: Feature request or enhancement labels Jan 18, 2025
@sai-harsha-vardhan sai-harsha-vardhan self-assigned this Jan 18, 2025
@sai-harsha-vardhan sai-harsha-vardhan requested review from a team as code owners January 18, 2025 17:30
Copy link

semanticdiff-com bot commented Jan 18, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  crates/router/src/routes/payments.rs  89% smaller
  crates/router/src/types.rs  73% smaller
  crates/router/src/core/payments.rs  57% smaller
  crates/hyperswitch_connectors/src/connectors/unified_authentication_service.rs  47% smaller
  crates/hyperswitch_connectors/src/connectors/unified_authentication_service/transformers.rs  40% smaller
  crates/router/src/core/payments/connector_integration_v2_impls.rs  36% smaller
  crates/hyperswitch_domain_models/src/types.rs  30% smaller
  crates/hyperswitch_domain_models/src/router_request_types/unified_authentication_service.rs  18% smaller
  crates/hyperswitch_interfaces/src/types.rs  15% smaller
  crates/hyperswitch_interfaces/src/api.rs  12% smaller
  crates/router/src/core/payments/operations/payment_confirm.rs  11% smaller
  crates/router/src/core/unified_authentication_service/types.rs  8% smaller
  crates/router/src/core/unified_authentication_service.rs  7% smaller
  crates/router/src/core/payments/flows.rs  5% smaller
  crates/hyperswitch_connectors/src/default_implementations.rs  2% smaller
  crates/hyperswitch_domain_models/src/router_flow_types/unified_authentication_service.rs  0% smaller
  crates/router/src/core/payments/helpers.rs  0% smaller
  crates/router/src/core/payments/operations.rs  0% smaller
  crates/router/src/core/unified_authentication_service/transformers.rs  0% smaller
  crates/router/src/core/unified_authentication_service/utils.rs Unsupported file format

@hyperswitch-bot hyperswitch-bot bot added M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jan 18, 2025
…-the-connector-creds-instead-of-connector_name' into external-auth-through-uas-core-flow-changes
@hyperswitch-bot hyperswitch-bot bot removed M-database-changes Metadata: This PR involves database schema changes M-api-contract-changes Metadata: This PR involves API contract changes labels Jan 18, 2025
@sai-harsha-vardhan sai-harsha-vardhan removed request for a team January 18, 2025 17:34
@sai-harsha-vardhan sai-harsha-vardhan removed the request for review from a team January 18, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-feature Category: Feature request or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant