return 410 Gone for deleted identity #692
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alphatownsman
force-pushed
the
410-gone
branch
from
49318ef
to
e04a22d
Compare
|
will run this on my site for a few weeks first, so set this as draft for now |
alphatownsman
force-pushed
the
410-gone
branch
from
e04a22d
to
02bda3a
Compare
|
@alphatownsman Has this worked? I want to shut down a Takahe instance and I feel that would be a safe way to communicate to other instances that the identity is gone, rather than just deleting the instance. |
|
it runs well for my instance for last few months, I had more aggressive changes locally that broadcast delete to all peers. I need to look at it again to see what I was thinking to be added before moving this out of Draft, but you can certainly take and use it. |
AstraLuma
requested changes
May 21, 2024
| canonicalise(identity.to_ap(), include_security=True), | ||
| content_type="application/activity+json", | ||
| ) | ||
| if identity.deleted and tz.now() - identity.deleted > tz.timedelta(days=3): |
There was a problem hiding this comment.
Can you not inline this formula? It's not complicated, but it is subtle and it took me a moment to figure out what it was doing and why.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instead of physically deleting a deleted identity, a more common and better practice is to return 410 Gone with type = Tombstone